Re: [PATCH] Allow unattended nfs3/krb5 mounts

From: Frank Cusack (fcusack@fcusack.com)
Date: Wed Jul 16 2003 - 03:44:26 EST


On Tue, Jul 15, 2003 at 11:26:05PM -0700, Frank Cusack wrote:
> - This doesn't actually work as-is. A separate patch is needed for
> rpc_setbufsize() which I will provide separately, after getting
> feedback for this patch.

Since I don't expect a known-broken patch to be applied ... here's
the bufsize patch.

        - fix null dereference on xprt->inet if !connected,
          which happens if a rpc cred wasn't available (root+auth_gss case)
        - set bufsize on reconnect

diff -uNrp linux-2.6.0-test1.2/net/sunrpc/clnt.c linux-2.6.0-test1.3/net/sunrpc/clnt.c
--- linux-2.6.0-test1.2/net/sunrpc/clnt.c Tue Jul 15 23:29:15 2003
+++ linux-2.6.0-test1.3/net/sunrpc/clnt.c Wed Jul 16 00:02:31 2003
@@ -385,7 +385,8 @@ rpc_setbufsize(struct rpc_clnt *clnt, un
         xprt->rcvsize = 0;
         if (rcvsize)
                 xprt->rcvsize = rcvsize + RPC_SLACK_SPACE;
- xprt_sock_setbufsize(xprt);
+ if (xprt_connected(xprt))
+ xprt_sock_setbufsize(xprt);
 }
 
 /*
diff -uNrp linux-2.6.0-test1.2/net/sunrpc/xprt.c linux-2.6.0-test1.3/net/sunrpc/xprt.c
--- linux-2.6.0-test1.2/net/sunrpc/xprt.c Tue Jul 15 23:29:15 2003
+++ linux-2.6.0-test1.3/net/sunrpc/xprt.c Wed Jul 16 00:02:37 2003
@@ -436,6 +436,7 @@ xprt_connect(struct rpc_task *task)
                 goto out_write;
         }
         xprt_bind_socket(xprt, sock);
+ xprt_sock_setbufsize(xprt);
 
         if (!xprt->stream)
                 goto out_write;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Jul 23 2003 - 22:00:23 EST