Re: 2.5.74 / oops with ppp_synctty and local_bh_enable

From: Ravikiran G Thirumalai (
Date: Tue Jul 08 2003 - 04:27:12 EST

On Mon, Jul 07, 2003 at 10:47:48AM -0500, Paul Fulghum wrote:
> ...
> Perhaps changing ppp_synctty.c to use spin_lock_irqsave
> and spin_lock_irqrestore is the best fix.

My 2 cents would be to keep it as it is. BK says WARN_ON was used
in place of BUG_ON in local_bh_enable just for the the ppp ldisc.

We all know tty locking is broken and needs rewrite, but
if we kill such symptoms at driver level, it'll probably deprive
some data points to whoever rewrites the tty layer.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Tue Jul 15 2003 - 22:00:26 EST