Re: 2.5.73-mm1 falling over in SDET

From: James Bottomley (James.Bottomley@steeleye.com)
Date: Sat Jun 28 2003 - 22:28:57 EST


On Sat, 2003-06-28 at 19:02, Andrew Morton wrote:
> Yes, isplinux_queuecommand() returns non-zero and the scsi generic layer
> cheerfully goes infinitely recursive.

Sigh, certain persons need to be more careful when doing logic
alterations.

Try the attached.

James


===== drivers/scsi/hosts.c 1.79 vs edited =====
--- 1.79/drivers/scsi/hosts.c Thu Jun 26 22:51:24 2003
+++ edited/drivers/scsi/hosts.c Sat Jun 28 22:14:12 2003
@@ -194,7 +194,7 @@
         shost->use_blk_tcq = sht->use_blk_tcq;
         shost->highmem_io = sht->highmem_io;
 
- if (!sht->max_host_blocked)
+ if (sht->max_host_blocked)
                 shost->max_host_blocked = sht->max_host_blocked;
         else
                 shost->max_host_blocked = SCSI_DEFAULT_HOST_BLOCKED;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jun 30 2003 - 22:00:30 EST