[TRIVIAL] avoid Oops in net/core/dev.c

From: Dan Aloni (da-x@gmx.net)
Date: Sat Jun 28 2003 - 03:38:10 EST

Linus, please apply.
Patrick, please read on.

This fixes the kernel crash in the case when we do an SIOCSIFNAME
ioctl on /proc/net/dev to rename a network interface, and
we supply a string such as "foo%sbar".

BTW, I've seen more places of this phenomenon, but they
are not with strings that come right from userspace like
this one.

BTW2, the attempt to rename the device here doesn't affect
sysfs. Patrick, we need a class_device_* interface that does
this.

--- linux-2.5.73/net/core/dev.c 2003-06-27 10:46:59.000000000 +0300
+++ linux-2.5.73/net/core/dev.c 2003-06-28 10:10:39.000000000 +0300
@@ -2346,7 +2346,7 @@
                                 return -EEXIST;
                         memcpy(dev->name, ifr->ifr_newname, IFNAMSIZ);
                         dev->name[IFNAMSIZ - 1] = 0;
- snprintf(dev->class_dev.class_id, BUS_ID_SIZE, dev->name);
+ strlcpy(dev->class_dev.class_id, dev->name, BUS_ID_SIZE);
                         notifier_call_chain(&netdev_chain,
                                             NETDEV_CHANGENAME, dev);
                         return 0; 

-- 
Dan Aloni
da-x@gmx.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Mon Jun 30 2003 - 22:00:28 EST