[PATCH] fix for kallsyms module symbol resolution problem

From: James Bottomley (James.Bottomley@steeleye.com)
Date: Fri Jun 27 2003 - 22:26:27 EST


In lots of KALLSYMS symbol resolution in modules, I've noticed the
appearance of symbols with no names:

Jun 27 20:55:26 raven kernel: [<10131440>] schedule_timeout+0x78/0xdc
Jun 27 20:55:26 raven kernel: [<000f8240>] +0x4e0/0x598 [sunrpc]
Jun 27 20:55:26 raven kernel: [<0014504c>] +0x150/0x43c [nfsd]
Jun 27 20:55:26 raven kernel: [<10109c5c>] ret_from_kernel_thread+0x1c/0x24

The problem seems to be that get_ksymbol doesn't eliminate empty symbol
names when it does resolution. The attached patch should fix this.

James


===== kernel/module.c 1.87 vs edited =====
--- 1.87/kernel/module.c Sat Jun 14 11:16:06 2003
+++ edited/kernel/module.c Fri Jun 27 22:10:58 2003
@@ -1760,7 +1760,8 @@
                         continue;
 
                 if (mod->symtab[i].st_value <= addr
- && mod->symtab[i].st_value > mod->symtab[best].st_value)
+ && mod->symtab[i].st_value > mod->symtab[best].st_value
+ && *(mod->strtab + mod->symtab[i].st_name) != '\0')
                         best = i;
                 if (mod->symtab[i].st_value > addr
                     && mod->symtab[i].st_value < nextval)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jun 30 2003 - 22:00:28 EST