Re: [PATCH] fix inlining with gcc3

From: Kurt Wall (kwall@kurtwerks.com)
Date: Thu Jun 26 2003 - 18:36:21 EST

Next message: J.A. Magallon: "[PATCH] kill extra printk prototype"
Previous message: J.A. Magallon: "[PATCH] kill duplicate pci_id"
In reply to: J.A. Magallon: "[PATCH] fix inlining with gcc3"
Next in thread: Alan Cox: "Re: [PATCH] fix inlining with gcc3"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

[CCs slightly trimmed]

Quoth J.A. Magallon:

[snippety]

> This fixes inlining (really, not-inlining) with gcc3. How about next -pre ?
>
> --- 25/include/linux/compiler.h~gcc3-inline-fix 2003-03-06 03:02:43.000000000 -0800
> +++ 25-akpm/include/linux/compiler.h 2003-03-06 03:11:42.000000000 -0800
> @@ -1,6 +1,13 @@
> #ifndef __LINUX_COMPILER_H
> #define __LINUX_COMPILER_H
>
> +#if __GNUC__ >= 3
> +#define inline __inline__ __attribute__((always_inline))
> +#define inline__ __inline__ __attribute__((always_inline))
> +#define __inline __inline__ __attribute__((always_inline))
> +#define __inline__ __inline__ __attribute__((always_inline))
> +#endif
> +
> /* Somewhere in the middle of the GCC 2.96 development cycle, we implemented
> a mechanism by which the user can annotate likely branch directions and
> expect the blocks to be reordered appropriately. Define __builtin_expect

I'm willing to give this a shot. Where, or perhaps what, should I test
to evaluate best the effects, if any, of this patch?

Kurt

-- 
Decision maker, n.:
	The person in your office who was unable to form a task force
before the music stopped.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: J.A. Magallon: "[PATCH] kill extra printk prototype"
Previous message: J.A. Magallon: "[PATCH] kill duplicate pci_id"
In reply to: J.A. Magallon: "[PATCH] fix inlining with gcc3"
Next in thread: Alan Cox: "Re: [PATCH] fix inlining with gcc3"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Jun 30 2003 - 22:00:25 EST