Re: [BUG] FIXMAP-related change to mm/memory.c

From: Riley Williams (Riley@Williams.Name)
Date: Fri Jun 13 2003 - 02:28:47 EST

Hi Linus, all.

>> Is it possible to constrain the FIXADDR range on x86/x86-64
>> (FIXADDR_START-FIXADDR_TOP) such that the entire range is
>> read-only by user-level? If so, we could simplify the
>> permission test like this:

> Well, you could replace the uses of FIXADDR_START/FIXADDR_TOP
> with something like FIXADDR_USER_START/FIXADDR_USER_TOP, and
> then force those to cover only the _one_ user-accessible page.
> Something like
> #define FIXADDR_USER_START (fix_to_virt(FIX_VSYSCALL))
> should work. In that case you can drop the page table testing,
> since we "know" it is safe.

Should FIXADDR_USER_END point to the last byte of the relevant page,
or to the first byte of the following page as per Linus's suggestion?
The above looks like an off-by-one bug to me?

Best wishes from Riley.

 * Nothing as pretty as a smile, nothing as ugly as a frown.

--- Outgoing mail is certified Virus Free. Checked by AVG anti-virus system ( Version: 6.0.488 / Virus Database: 287 - Release Date: 5-Jun-2003

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to More majordomo info at Please read the FAQ at

This archive was generated by hypermail 2b29 : Sun Jun 15 2003 - 22:00:35 EST