Re: [PATCH] First casuality of hlist poisoning in 2.5.70

From: Linus Torvalds (
Date: Wed Jun 11 2003 - 19:32:16 EST

On Wed, 11 Jun 2003, Trond Myklebust wrote:
> AFAICS one should not rehash the dentry until after the d_move(). Does
> that make sense?

Yeah, it does seem that rehashing before actually calling d_move() means
that there is a small window where another process might now come in, and
use the dcache (without getting the semaphore) to see the old value of the
target dentry, even though the low-level filesystem has already move the
new dentry value over the target. Ie the window would be between

        ... race here ...
        d_move(old_dentry, new_dentry)

That might confuse a filesystem that expected that the target was deleted
an no longer reachable by anybody.

Al? What do you think?


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Sun Jun 15 2003 - 22:00:30 EST