Re: Coding standards. (Was: Re: [PATCH] [2.5] Non-blocking write can block)

From: Jörn Engel (
Date: Mon Jun 09 2003 - 13:22:49 EST

On Mon, 9 June 2003 11:07:32 -0700, Davide Libenzi wrote:
> You know why the code you reported is *wrong* (besides from how
> techincally do things) ? Mixing lower and upper case, using long variable
> and function names, etc... are simply a matter of personal taste and you
> cannot say that such code is "absolutely" wrong. The code is damn wrong
> because it violates about 25 sections of the project's defined CodingStyle
> document, that's why it is wrong.

Call it as you may. Whether some style violates more sections of the
CodingStyle than exist in written form or it hurts the taste of 99% of
all developers ever having to tough it, my short form for that is "bad

Point remains, there is a lot of "bad style" and inconsistency in the
kernel. But fixing all of it and keeping it fixed would result in a
lot of work and maybe a couple of device drivers less. For what gain?


Measure. Don't tune for speed until you've measured, and even then
don't unless one part of the code overwhelms the rest.
-- Rob Pike
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Sun Jun 15 2003 - 22:00:21 EST