Re: [PATCH] hugetlbfs: fix error reporting in case of invalid mount options

From: William Lee Irwin III (
Date: Sat Jun 07 2003 - 11:35:21 EST

On Sat, Jun 07, 2003 at 02:55:32PM +0200, Ren? Scharfe wrote:
> there is not much point in trying to print the mount options after
> hugetlbfs_parse_options() went over them.
> Since it employs strsep(), it cuts the option string into pieces by
> replacing all commas with NUL characters. A following printk() will
> always show the first option, only, which could be confusing.
> The patch below changes hugetlbfs to not try to echo the string of
> mount options in case of an error at all. It wouldn't tell us anything
> we didn't know before, anyway.

Let's nuke it entirely. All other fs's barf without printk()'ing at all
and kick -EINVAL back to the caller.

-- wli
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Sat Jun 07 2003 - 22:00:33 EST