Re: __user annotations

From: Hollis Blanchard (
Date: Fri Jun 06 2003 - 11:46:42 EST

On Thursday, Jun 5, 2003, at 17:07 US/Central, Linus Torvalds wrote:
> On Thu, 5 Jun 2003, Hollis Blanchard wrote:
>> Two ioctl functions in sound/oss/awe_wave.c were directly
>> dereferencing
>> a user-supplied pointer in a few places. Please apply.
> When you do patches like this, can you please add the "__user"
> annotations
> while you're at it?

I was hoping for a little more explanation on that before I used it...
for example, will the following code generate a warning? An error?

void func_b(void *b) { }

void func_a(__user void *a)

How about the other way, passing a normal pointer to a function with
__user in its prototype?

I'm just worried that as soon as I use __user once, entire call chains
are going to start spewing warnings/errors.

> Also, if your mailer doesn't rape whitespace, I
> seriously prefer patches in-line in the email, so that I don't have to
> edit the email and can reply to it directly?

I was under the impression that text/plain attachments were ok with
you, but it looks like inline will work too.

Hollis Blanchard
IBM Linux Technology Center

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to More majordomo info at Please read the FAQ at

This archive was generated by hypermail 2b29 : Sat Jun 07 2003 - 22:00:30 EST