Re: __check_region in ide code?

From: William Lee Irwin III (
Date: Fri Jun 06 2003 - 06:31:28 EST

On Fri, Jun 06, 2003 at 05:34:24PM +1000, Rusty Russell wrote:
> I notice that drivers/ide/ide-probe.c's hwif_check_region()
> still uses check_region(). If it really does want to use it to probe
> and not reserve, I think we should stop it warning there.
> There's nothing inherently *wrong* with check_region, it's
> just deprecated to trap the old (now racy) idiom of "if
> (check_region(xx)) reserve_region(xx)". There's no reason not to
> introduce a probe_region if IDE really wants it.
> Of course, some people will start "fixing" drivers by
> s/check_region/probe_region/ when we do this, but that's the risk we
> take.
> It should also allow us to easily get rid of that stupid warning in
> ksyms.c...

I've actually seen IDE oops doing a racy check_region()/request_region()
on 2.4.x-test*. Either the fix I brewed up never hit mainline or there's
more than the one I hit.

-- wli
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Sat Jun 07 2003 - 22:00:30 EST