Re: [PATCH] More PCI fixes for 2.5.70

From: Greg KH (greg@kroah.com)
Date: Thu Jun 05 2003 - 16:01:17 EST


ChangeSet 1.1312, 2003/06/05 12:03:40-07:00, greg@kroah.com

[PATCH] PCI: remove direct access of pci_devices from drivers/macintosh/via-pmu68k.c

Yeah, this is commented out code, but just trying to be complete...

 drivers/macintosh/via-pmu68k.c | 11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

diff -Nru a/drivers/macintosh/via-pmu68k.c b/drivers/macintosh/via-pmu68k.c
--- a/drivers/macintosh/via-pmu68k.c Thu Jun 5 13:53:06 2003
+++ b/drivers/macintosh/via-pmu68k.c Thu Jun 5 13:53:06 2003
@@ -839,11 +839,11 @@
 pbook_pci_save(void)
 {
         int npci;
- struct pci_dev *pd;
+ struct pci_dev *pd = NULL;
         struct pci_save *ps;
 
         npci = 0;
- for (pd = pci_devices; pd != NULL; pd = pd->next)
+ while ((pd = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, pd)) != NULL)
                 ++npci;
         n_pbook_pci_saves = npci;
         if (npci == 0)
@@ -853,7 +853,8 @@
         if (ps == NULL)
                 return;
 
- for (pd = pci_devices; pd != NULL && npci != 0; pd = pd->next) {
+ pd = NULL;
+ while ((pd = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, pd)) != NULL) {
                 pci_read_config_word(pd, PCI_COMMAND, &ps->command);
                 pci_read_config_word(pd, PCI_CACHE_LINE_SIZE, &ps->cache_lat);
                 pci_read_config_word(pd, PCI_INTERRUPT_LINE, &ps->intr);
@@ -867,10 +868,10 @@
 {
         u16 cmd;
         struct pci_save *ps = pbook_pci_saves;
- struct pci_dev *pd;
+ struct pci_dev *pd = NULL;
         int j;
 
- for (pd = pci_devices; pd != NULL; pd = pd->next, ++ps) {
+ while ((pd = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, pd)) != NULL) {
                 if (ps->command == 0)
                         continue;
                 pci_read_config_word(pd, PCI_COMMAND, &cmd);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jun 07 2003 - 22:00:28 EST