Re: [BK PATCH] PCI and PCI Hotplug changes and fixes for 2.5.70

From: Dave Jones (
Date: Thu Jun 05 2003 - 04:18:02 EST

On Thu, Jun 05, 2003 at 02:06:45AM -0700, Greg KH wrote:
> > so why not..
> >
> > #define pci_for_each_dev(dev) \
> > while ((device = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, device)) != NULL)
> >
> > ?
> >
> > Seems to be the same change you made tree-wide, with minimal
> > interruption to drivers.
> But that would have changed the way that pci_for_each_dev() works.
> It would require that dev=NULL before the function is called.

trivial to fix.

> And having
> the same function work subtly different on different kernel versions
> would not be the best thing.

> Getting rid of it entirely was the better
> option, and now that Linus has pulled it, we don't have to worry about
> it anymore :)

The fact that a tree-wide 'cleanup' like this goes in just a few hours
after its posted before chance to comment is another argument, but
concentrating on the technical point here, I still think this is a
step backwards.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Sat Jun 07 2003 - 22:00:26 EST