Re: [PATCH] [2.5] Non-blocking write can block

From: Linus Torvalds (
Date: Wed Jun 04 2003 - 09:35:47 EST

On Wed, 4 Jun 2003, Christoph Hellwig wrote:
> The else should be on the same line as the closing brace, else
> the patch looks fine.

No no no, it's wrong.

If you do something like this, then you also have to teach "select()"
about this, otherwise you just get busy looping in applications.

In general, we shouldn't do this, unless somebody can show an application
where it really matters. Taking internal kernel locking into account for
"blockingness" easily gets quite complicated, and there is seldom any real
point to it.

Remember: perfect is the enemy of good. I'll happily apply the patch (if
it also updates the tty poll() functionality), _if_ there is some
real-world situation where it matters.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Sat Jun 07 2003 - 22:00:23 EST