Re: Question about style when converting from K&R to ANSI C.

From: Steven Cole (
Date: Sun Jun 01 2003 - 11:46:19 EST

On Sun, 2003-06-01 at 10:11, Larry McVoy wrote:
> On Sun, Jun 01, 2003 at 09:04:22AM -0700, Jonathan Lundell wrote:
> > The reason I've liked this format is that it gives me a quick and
> > universal way to find *specific* functions with vi or grep, by
> > searching for "^function_name(".
> Exactly. I thought of making that point in my original posting and
> figured everyone would tell me to use tags and I didn't want to have
> to remember all the other reasons I wanted this.
> It really is nice knowing that "^function_name(" is the definition.

Thanks for the input. You've convinced me. When going through
arch/ppc/xmon/xmon.c, I will leave things like the following unchanged:

/* Command interpreting routine */
static int
cmds(struct pt_regs *excp)

My changes will be similar to the following:

@@ -1837,9 +1818,7 @@
        return *lineptr++;

-char *str;
+void take_input(char *str)
        lineptr = str;

I'll be changing the return type/function name line orientation only
when making other changes. And these will still go through the
applicable maintainers.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Sat Jun 07 2003 - 22:00:14 EST