Re: [Linux-fbdev-devel] [PATCH] fix controlfb and platinumfbdrivers

[Benjamin Herrenschmidt (benh@kernel.crashing.org)]

On Wed, 2003-05-28 at 01:08, Paul Mackerras wrote:
> James Simmons writes:
> 
> > Applied. Tho it is strnage. You shouldn't need to call fb_set_var from the 
> > driver. 
> 
> It's just convenient to use fb_set_var to get the hardware set to the
> initial mode.  Would it be better to call controlfb_check_var,
> controlfb_set_par, etc., directly?

I think we are supposed to rely on the console subsytem opening us thus
doing a set_par() with the initial var rather than doing set_var ourselves,
but I'm not too sure, I added those set_var at a time where I had incorrect
results without, we may be able to remove them by now...

Ben.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/