2.4.21-rc5 - drivers/ide/pci/via82cxxx.c (PCI_DEVICE_ID_VIA_8237)

[Damian Kołkowski (deimos@deimos.one.pl)]

Hi,

With new -rc5 there is, something like add new:
{ "vt8237",     PCI_DEVICE_ID_VIA_8237,     0x00, 0x2f, VIA_UDMA_133 |
VIA_BAD_AST },

This is not correct.

After make bzImage I have:

(...)
make[4]: Entering directory `/usr/src/linux-2.4.20/drivers/ide/pci'
gcc -D__KERNEL__ -I/usr/src/linux-2.4.20/include -Wall -Wstrict-prototypes
-Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -pipe
-mpreferred-stack-boundary=2 -march=athlon  -I../ -nostdinc -iwithprefix
include -DKBUILD_BASENAME=via82cxxx  -c -o via82cxxx.o via82cxxx.c
via82cxxx.c:78: `PCI_DEVICE_ID_VIA_8237' undeclared here (not in a function)
via82cxxx.c:78: initializer element is not constant
via82cxxx.c:78: (near initialization for `via_isa_bridges[0].id')
via82cxxx.c:78: initializer element is not constant
via82cxxx.c:78: (near initialization for `via_isa_bridges[0]')
(...)

So, you better live it in / FUTURE_BRIDGES / like it was before or something
;-)

P.S. It works, but I don't know if it supose to be that:

#ifdef FUTURE_BRIDGES
        { "vt8237",     PCI_DEVICE_ID_VIA_8237,     0x00, 0x2f, VIA_UDMA_133 | VIA_BAD_AST },
#endif

Take care.

-- 
# Damian *dEiMoS* Kołkowski # http://deimos.one.pl/ #
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/