Re: [patch] cache flush bug in mm/filemap.c (all kernels >=2.5.30(at least))

From: David S. Miller (davem@redhat.com)
Date: Tue May 27 2003 - 16:29:24 EST


From: Roman Zippel <zippel@xxxxxxxxxxxxxx>
Date: Tue, 27 May 2003 12:53:12 +0200 (CEST)

The point I don't like about update_mmu_cache() is that it's called
_after_ set_pte(). Practically it's maybe not a problem right now, but
the cache synchronization should happen before set_pte().

update_mmu_cache() is specifically supposed to always occur before
anyone could try to use the mapping created.

If this is ever violated, it will be fixed because it is a BUG().

So I don't see what you're worried about.

If the above were not true, sparc64 wouldn't be able to compile
a kernel successfully. :-)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/