Re: [PATCH] xirc2ps_cs irq return fix

[Andrew Morton (akpm@digeo.com)]

Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
>
> If the fix is correct, we need to do a bombing run that adds the 
>  following code to each driver,
> 
>  	if (!netif_device_present(dev))
>  		return IRQ_HANDLED;

no...  What we need to do is to kill the printk in handle_IRQ_event().

It should only be turned on for special situations, where someone is trying
to hunt down a reproducible lockup.  These are situations in which the odd
false positive just doesn't matter.  And we know that there will always
be false positives due to apic delivery latency (at least).

I think the time is right to do this.  Add CONFIG_DEBUG_IRQ and get on with
fixing real stuff.



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/