Re: [RFC] [PATCH] Add 'make' with no target as preferred build command

From: Sam Ravnborg (sam@ravnborg.org)
Date: Mon May 26 2003 - 15:38:08 EST


On Mon, May 26, 2003 at 06:29:07PM +0100, Paulo Andre' wrote:
> Hello,
>
> It seems for 2.5/2.6 'make' is the preferred command for building the
> kernel tree (also stated in davej's 2.6 "what to expect" document). That
> scenario however isn't even presented when the user finishes the kernel
> configuration. This is a simple patch to scripts/kconfig/mconf.c which
> tackles that, perhaps not in the best fashion but certainly in the
> simplest.

If we really want this boilerplate text then bzImage should not be
present. It is i386 centric.
Revised patch below. Also made it a bit more readable by wrapping
a long line.

Roman Zippel cc:ed as he is the kconfig maintainer.

Sam

===== scripts/kconfig/mconf.c 1.5 vs edited =====
--- 1.5/scripts/kconfig/mconf.c Sat Mar 15 18:25:55 2003
+++ edited/scripts/kconfig/mconf.c Mon May 26 22:30:47 2003
@@ -780,10 +780,12 @@
conf_write(NULL);
printf("\n\n"
"*** End of Linux kernel configuration.\n"
- "*** Check the top-level Makefile for additional configuration.\n"
- "*** Next, you may run 'make bzImage', 'make bzdisk', or 'make install'.\n\n");
+ "*** Execute 'make' to build the kernel"
+ " or try 'make help'.\n\n");
} else
- printf("\n\nYour kernel configuration changes were NOT saved.\n\n");
+ printf("\n\n"
+ "*** Your kernel configuration changes were NOT saved."
+ "\n\n");

return 0;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/