The previous 2.4 ioperm fix is broken. This patch against 2.4.21-rc3
fixes the fix, so that ioperm actually works. The "fixed" ioperm was
only copying 1/4th of the bitmap, not the whole thing. The real-world
bug was that FCE Ultra (and possibly other svgalib apps) tended to
segfault rather than actually run.
This patch also backports the IO_BITMAP_BYTES #define from 2.5, because
IO_BITMAP_SIZE can be a mental booby trap in some contexts. If that's
too invasive, let me know, but IMO it makes the code cleaner and it's
an obviously correct change.
-Barry K. Nathan <barryn@pobox.com>
diff -ruN linux-2.4.21-rc3/arch/i386/kernel/ioport.c linux-2.4.21-rc3-bkn1/arch/i386/kernel/ioport.c
--- linux-2.4.21-rc3/arch/i386/kernel/ioport.c 2003-05-22 23:04:48.000000000 -0700
+++ linux-2.4.21-rc3-bkn1/arch/i386/kernel/ioport.c 2003-05-23 02:10:23.000000000 -0700
@@ -81,7 +81,7 @@
if (tss->bitmap == IO_BITMAP_OFFSET) { /* already active? */
set_bitmap(tss->io_bitmap, from, num, !turn_on);
} else {
- memcpy(tss->io_bitmap, t->io_bitmap, IO_BITMAP_SIZE);
+ memcpy(tss->io_bitmap, t->io_bitmap, IO_BITMAP_BYTES);
tss->bitmap = IO_BITMAP_OFFSET; /* Activate it in the TSS */
}
diff -ruN linux-2.4.21-rc3/arch/i386/kernel/process.c linux-2.4.21-rc3-bkn1/arch/i386/kernel/process.c
--- linux-2.4.21-rc3/arch/i386/kernel/process.c 2003-03-26 16:42:28.000000000 -0800
+++ linux-2.4.21-rc3-bkn1/arch/i386/kernel/process.c 2003-05-23 02:12:36.000000000 -0700
@@ -727,7 +727,7 @@
* is not really acceptable.]
*/
memcpy(tss->io_bitmap, next->io_bitmap,
- IO_BITMAP_SIZE*sizeof(unsigned long));
+ IO_BITMAP_BYTES);
tss->bitmap = IO_BITMAP_OFFSET;
} else
/*
diff -ruN linux-2.4.21-rc3/include/asm-i386/processor.h linux-2.4.21-rc3-bkn1/include/asm-i386/processor.h
--- linux-2.4.21-rc3/include/asm-i386/processor.h 2003-05-23 01:30:01.000000000 -0700
+++ linux-2.4.21-rc3-bkn1/include/asm-i386/processor.h 2003-05-23 02:08:15.000000000 -0700
@@ -281,6 +281,7 @@
* Size of io_bitmap in longwords: 32 is ports 0-0x3ff.
*/
#define IO_BITMAP_SIZE 32
+#define IO_BITMAP_BYTES (IO_BITMAP_SIZE * 4)
#define IO_BITMAP_OFFSET offsetof(struct tss_struct,io_bitmap)
#define INVALID_IO_BITMAP_OFFSET 0x8000
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri May 23 2003 - 22:00:54 EST