Re: [patch?] truncate and timestamps

From: Trond Myklebust (trond.myklebust@fys.uio.no)
Date: Fri May 23 2003 - 00:11:33 EST


>>>>> " " == Andrew Morton <akpm@digeo.com> writes:

> I assume every foo_truncate() is doing

    inode-> i_mtime = inode->i_ctime = CURRENT_TIME;
> mark_inode_dirty(inode);

> and as Andries says, we can probably pull all that up to the
> VFS level.

No. Please do not assume that the above is equivalent to calling
notify_change() with ATTR_MTIME|ATTR_CTIME.

NFS tends to leave the above to the server side, since the clocks may
be desynchronized between client and server.

As far as NFS is concerned, we should only be setting ATTR_*TIME if/when
the *user* specifies it through a utimes() call or something like that.

Cheers,
  Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri May 23 2003 - 22:00:53 EST