Re: try_then_request_module

From: Rusty Russell (rusty@rustcorp.com.au)
Date: Mon May 19 2003 - 19:19:00 EST

Next message: Chris Friesen: "Re: Problem in ARP 2.4.20 kernel"
Previous message: Valdis.Kletnieks@vt.edu: "Re: [patch] futex requeueing feature, futex-requeue-2.5.69-D3"
In reply to: Ingo Oeser: "Re: try_then_request_module"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

In message <20030519110832.G626@nightmaster.csn.tu-chemnitz.de> you write:
> So try_then_request_module() will consolidate the the
> branch or in the worst case just duplicating that code
> everywhere (depends on wether you implement it as a non-inline
> function or define).

I'm not speculating: here it is from kmod.h:

#define try_then_request_module(x, mod...) ((x) ?: request_module(mod), (x))

It really should be:

#ifdef CONFIG_KMOD
#define try_then_request_module(x, mod...) ((x) ?: request_module(mod), (x))
#else
#define try_then_request_module(x, mod...) (x)
#endif /* CONFIG_KMOD */

Patches welcome.

Getting rid of the CONFIG_KMOD's in general code without leaving
unused code around is the aim here.

Hope that clarifies!
Rusty.

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Chris Friesen: "Re: Problem in ARP 2.4.20 kernel"
Previous message: Valdis.Kletnieks@vt.edu: "Re: [patch] futex requeueing feature, futex-requeue-2.5.69-D3"
In reply to: Ingo Oeser: "Re: try_then_request_module"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri May 23 2003 - 22:00:38 EST