Re: [PATCH] Added missing dependencies on CRYPTO_HMAC

From: Adrian Bunk (bunk@fs.tum.de)
Date: Sun May 18 2003 - 10:14:12 EST


On Sun, May 18, 2003 at 01:40:28PM +1000, James Morris wrote:
> On Sun, 18 May 2003, Herbert Xu wrote:
>
> > On Sun, May 18, 2003 at 12:19:09PM +1000, James Morris wrote:
> > >
> > > See crypto/Kconfig, CRYPTO_HMAC is being defaulted to Y if these protocols
> > > are selected.
> >
> > Yes, but the user can then set them to no. This does happen as the
> > Crypto menu is listed after Networking so someone going through it
> > in that order can select INET_AH and then go on to disable Crypto.
>
> Yes, we allow users to override the defaults if they wish, at their own
> peril.
>...

The real problems are more subtle:
Consider someone uses neither CRYPTO_HMAC nor INET_AH and later changes
his .config using menuconfig - the "default" does _nothing_ since
CRYPTO_HMAC already has a value.

Thinking more about this issue it seems the "enable" feature in the
latest Kconfig patch will be the correct solution.

> James Morris

cu
Adrian

-- 

"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri May 23 2003 - 22:00:30 EST