Jeff Garzik wrote:
>> dev_kfree_skb(skb);
>> - else
>> - netif_wake_queue(dev);
>> + netif_wake_queue(dev);
>> LEAVE("iph5526_send_packet");
>
>
>
> This appears to revert a fix.
>
> You only want to wake the queue if you have room to queue another skb.
Actually, I'm wrong.
But it could still use some looking-at. You don't want to stop_queue at
the beginning of send_packet and wake_queue at the end. Instead, the
queue should be awakened in the Tx completion routine, and the
stop_queue should be moved from the beginning to the end of the function.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu May 15 2003 - 22:00:55 EST