Re: [PATCH]: set state to XFRM_STATE_DEAD before calling xfrm_state_put in pfkey_msg2xfrm_state

• Next message: David S. Miller: "Re: [PATCH][ATM] add reference counting to atm_dev"
• Previous message: Alex Davis: "link error building kernel with gcc-3.3"
• In reply to: David S. Miller: "Re: [PATCH]: set state to XFRM_STATE_DEAD before calling xfrm_state_put in pfkey_msg2xfrm_state"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

David S. Miller wrote:

>You didn't test this change. x->type is a pointer, not a place where
>you put XFRM_STATE_DEAD, a simple compile test would have alerted
>this to you.
>
>

Sorry about that, i recreated the fix in a different tree and broke it.

>This also means you couldn't possibly have tested if this even
>makes the assertion go away, it couldn't possibly have fixed this..
>
>The correct fix, of course, is to set x->km.state to this value.
>This is what I've done in my tree.
>
>Please be a LOT more careful with your changes.
>

Promised.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: David S. Miller: "Re: [PATCH][ATM] add reference counting to atm_dev"
• Previous message: Alex Davis: "link error building kernel with gcc-3.3"
• In reply to: David S. Miller: "Re: [PATCH]: set state to XFRM_STATE_DEAD before calling xfrm_state_put in pfkey_msg2xfrm_state"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu May 15 2003 - 22:00:53 EST