Re: ioctl32: kill code duplication (sparc64 tester wanted)

From: Christoph Hellwig (hch@infradead.org)
Date: Mon May 12 2003 - 08:08:34 EST


On Mon, May 12, 2003 at 03:05:19PM +0200, Pavel Machek wrote:
> Hi!
> > I don't have a sparc64, but there's certainly no <asm/mtrr.h> for
> > > that arch..
>
> I thought I killed that one?

The patch you attached added it..

> > Also #including c files is ugly as hell. What's the #ifdef INCLUDES
> > supposed to help?
>
> Yes, but do you have better proposal how to kill 4000+ lines of code
> from each 64-bit architecture?

What's the reason you can't build fs/compat_ioctl.c normally and pull
in the arch magic through a magic asm/ header? You still haven't answered
the second question, btw..
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu May 15 2003 - 22:00:39 EST