Re: [ATM] [UPDATE] unbalanced exit path in Forerunner HE he_init_one() (and an iphase patch too!)

From: Francois Romieu (romieu@fr.zoreil.com)
Date: Sat May 10 2003 - 05:54:43 EST

Next message: David S. Miller: "Re: qla1280 mem-mapped I/O fix"
Previous message: Luc de Louw: "[PATCHLET] for typo in reiserfs in 2.4.21-rc2"
In reply to: chas williams: "Re: [ATM] [UPDATE] unbalanced exit path in Forerunner HE he_init_one() (and an iphase patch too!)"
Next in thread: chas williams: "Re: [ATM] [PATCH] unbalanced exit path in Forerunner HE he_init_one()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

chas williams <chas@locutus.cmf.nrl.navy.mil> :
[...]
> i hope you dont mind, but i really dislike the goto. one is plenty.

I am not fond of the 'test before destruction' approach when the tests
could have been avoided. Anyway you maintain the driver on a regular basis,
you are free to choose the fix.

> attached is a cleanup for the iphase (i made a small addition -- i believe
> the MEMDUMP_XXXXXXREG cases are also guilty of dereferencing).

Yes.

--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: David S. Miller: "Re: qla1280 mem-mapped I/O fix"
Previous message: Luc de Louw: "[PATCHLET] for typo in reiserfs in 2.4.21-rc2"
In reply to: chas williams: "Re: [ATM] [UPDATE] unbalanced exit path in Forerunner HE he_init_one() (and an iphase patch too!)"
Next in thread: chas williams: "Re: [ATM] [PATCH] unbalanced exit path in Forerunner HE he_init_one()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu May 15 2003 - 22:00:33 EST