Re: [PATCH][2.4] cleanup ptrace secfix and fix most side effects

From: Alan Cox (alan@lxorguk.ukuu.org.uk)
Date: Thu May 08 2003 - 16:31:37 EST


On Iau, 2003-05-08 at 23:05, Bernhard Kaindl wrote:
> - mb();
> - if (!is_dumpable(child))
> - return -EPERM;
>
> if (!(child->ptrace & PT_PTRACED))
> return -ESRCH;
>
> Using is_dumpable() here is not neccesary because the checks done here are:
>
> > if (!(child->ptrace & PT_PTRACED))
> > return -ESRCH;

Except that current->mm->dumpable is not per task but per mm so you
might ptrace one thread and have another go setuid.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu May 15 2003 - 22:00:29 EST