On Thu, May 08 2003, Bartlomiej Zolnierkiewicz wrote:
>
> On 8 May 2003, Alan Cox wrote:
> > On Iau, 2003-05-08 at 14:35, Bartlomiej Zolnierkiewicz wrote:
> > > Yep, you are right, hwif->addressing logic is reversed, what a mess.
> >
> > No the problem is you keep treating it as a binary value. Addressing is
> > a mode. Right now 0 is LBA28/CHS and 1 is LBA48. SATA next generation
For drive->addressing, not hwif.
> > stuff extends this even further so will I imagine be addressing=2
>
> You are right but currently it is a binary value.
> The same goes for actual usage of drive->addressing and comment in ide.h.
Maybe a define or two would help here. When you see drive->addressing
and hwif->addressing, you assume that they are used identically. That
!hwif->addressing means 48-bit is ok, while !drive->addressing means
it's not does not help at all.
#define IDE_LBA28 0
#define IDE_LBA48 1
and then change hwif->addressing to be addressed like the drive variant
would help a whole lot.
-- Jens Axboe- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu May 15 2003 - 22:00:28 EST