Re: [PATCH] TTY changes for 2.5.69

From: Greg KH (greg@kroah.com)
Date: Wed May 07 2003 - 18:16:27 EST


ChangeSet 1.1106, 2003/05/07 15:00:52-07:00, hannal@us.ibm.com

[PATCH] isicom tty_driver add .owner field remove MOD_INC/DEC_USE_COUNT

 drivers/char/isicom.c | 8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

diff -Nru a/drivers/char/isicom.c b/drivers/char/isicom.c
--- a/drivers/char/isicom.c Wed May 7 16:00:43 2003
+++ b/drivers/char/isicom.c Wed May 7 16:00:43 2003
@@ -590,9 +590,7 @@
                                                         port->status &= ~ISI_DCD;
                                                         if (!((port->flags & ASYNC_CALLOUT_ACTIVE) &&
                                                                 (port->flags & ASYNC_CALLOUT_NOHUP))) {
- MOD_INC_USE_COUNT;
- if (schedule_task(&port->hangup_tq) == 0)
- MOD_DEC_USE_COUNT;
+ schedule_task(&port->hangup_tq);
                                                         }
                                                 }
                                         }
@@ -846,7 +844,6 @@
 #endif
         
         bp->status |= BOARD_ACTIVE;
- MOD_INC_USE_COUNT;
         return;
 }
  
@@ -1104,7 +1101,6 @@
         for(channel = 0; channel < bp->port_count; channel++, port++) {
                 drop_dtr_rts(port);
         }
- MOD_DEC_USE_COUNT;
 }
 
 static void isicom_shutdown_port(struct isi_port * port)
@@ -1644,7 +1640,6 @@
         tty = port->tty;
         if (tty)
                 tty_hangup(tty); /* FIXME: module removal race here - AKPM */
- MOD_DEC_USE_COUNT;
 }
 
 static void isicom_hangup(struct tty_struct * tty)
@@ -1715,6 +1710,7 @@
         /* tty driver structure initialization */
         memset(&isicom_normal, 0, sizeof(struct tty_driver));
         isicom_normal.magic = TTY_DRIVER_MAGIC;
+ isicom_normal.owner = THIS_MODULE;
         isicom_normal.name = "ttyM";
         isicom_normal.major = ISICOM_NMAJOR;
         isicom_normal.minor_start = 0;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed May 07 2003 - 22:00:33 EST