Re: Re:[2.5] Update sk98lin driver

• Next message: Felipe Alfaro Solana: "Re: will be able to load new kernel without restarting?"
• Previous message: Linus Torvalds: "Linux 2.5.69"
• In reply to: Martin Schlemmer: "Re: Re:[2.5] Update sk98lin driver"
• Next in thread: Andrew Morton: "Re: [2.5] Update sk98lin driver"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sun, 2003-05-04 at 16:56, Martin Schlemmer wrote:
> A few issues though:
>
> 1) Should MOD_INC_USE_COUNT and MOD_DEC_USE_COUNT just be removed?
> I commented them for now.

No. For the net device itself, make sure you do
SET_MODULE_OWNER() on the netdev before passing it
to register_netdevice().

For the procfs stuff you must make sure the appropriate
module refcounting is done for that mechanism.

Just deleteing MOD_{INC,DEC}_USE_COUNT blindly will result
in the module being broken.

-- 
David S. Miller <davem@redhat.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Felipe Alfaro Solana: "Re: will be able to load new kernel without restarting?"
• Previous message: Linus Torvalds: "Linux 2.5.69"
• In reply to: Martin Schlemmer: "Re: Re:[2.5] Update sk98lin driver"
• Next in thread: Andrew Morton: "Re: [2.5] Update sk98lin driver"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed May 07 2003 - 22:00:20 EST