Re: [RFC] how to fix is_local_disk()?

From: Andrew Morton (akpm@digeo.com)
Date: Sun May 04 2003 - 02:30:21 EST


Christoph Hellwig <hch@lst.de> wrote:
>
> In drivers/char/sysrq.c we have this nice piece of code:
>

Suggest you chainsaw the whole lot and simply do a wakeup_bdflush(0) from
interrupt context.

The only functional change I can see with this is that it could cause pdflush
to get stuck if there are dead NFS/SMBFS/etc mounts.

But if that happens, we need to fix it anyway. Those filesystems should
avoid getting stuck if called with writeback_control.sync_mode != WB_SYNC_ALL,
especially if current_is_pdflush() returns true.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed May 07 2003 - 22:00:19 EST