Re: [PATCH] aha1740 update

From: Marc Zyngier (mzyngier@freesurf.fr)
Date: Thu Apr 24 2003 - 08:34:25 EST

Next message: Werner Almesberger: "Re: [Bug 623] New: Volume not remembered."
Previous message: David van Hoose: "ALSA and 2.4.x"
In reply to: Christoph Hellwig: "Re: [PATCH] aha1740 update"
Next in thread: Christoph Hellwig: "Re: [PATCH] aha1740 update"
Reply: Christoph Hellwig: "Re: [PATCH] aha1740 update"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

>>>>> "CH" == Christoph Hellwig <hch@infradead.org> writes:

>> +/* This should really fit in driver/scsi/scsi.h, along with
>> + * scsi_to_{pci,sbus}_dma_dir.... */

CH> Right. Please submit a patch to James.

I think this would cause some troubles. I would have to include
linux/dma-mapping in driver/scsi/scsi.h, but many non-PCI
architectures are still including asm-generic/dma-mapping.h, which has
lots of references to PCI functions... I'm afraid this would clash
badly on, say, sparc or m68k...

CH> Well, and as you're touching the driver big time a cleanup to follow
CH> Documentation/CondingStyle would be nice.

I totally agree with the rest of your comments, and will submit an
updated patch shortly.

Thanks,

-- 
Places change, faces change. Life is so very strange.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Werner Almesberger: "Re: [Bug 623] New: Volume not remembered."
Previous message: David van Hoose: "ALSA and 2.4.x"
In reply to: Christoph Hellwig: "Re: [PATCH] aha1740 update"
Next in thread: Christoph Hellwig: "Re: [PATCH] aha1740 update"
Reply: Christoph Hellwig: "Re: [PATCH] aha1740 update"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed Apr 30 2003 - 22:00:14 EST