Re: [PATCH] 2.5.68-bk1 crash in devfs_remove() for defpts files

From: Christoph Hellwig (hch@lst.de)
Date: Mon Apr 21 2003 - 14:00:20 EST


On Mon, Apr 21, 2003 at 02:53:54PM -0400, Pavel Roskin wrote:
> On Mon, 21 Apr 2003, Christoph Hellwig wrote:
>
> > On Mon, Apr 21, 2003 at 07:55:55PM +0200, Christoph Hellwig wrote:
> > > Could you please try this patch?
> >
> > Better this one :) Sorry.
>
> No, it doesn't help, although the stack trace is different this time:

Hmm. Can you please apply the following patch in addition and
see what the printk I added sais?

--- 1.87/fs/devfs/base.c Mon Apr 21 10:43:52 2003
+++ edited/fs/devfs/base.c Mon Apr 21 19:36:20 2003
@@ -1754,6 +1803,12 @@
         n = vsnprintf(buf, 64, fmt, args);
         if (n < 64 && buf[0]) {
                 devfs_handle_t de = _devfs_find_entry(NULL, buf, 0);
+
+ if (!de) {
+ printk(KERN_WARNING "%s: no entry for %s!\n",
+ __FUNCTION__, buf);
+ return;
+ }
 
                 write_lock(&de->parent->u.dir.lock);
                 _devfs_unregister(de->parent, de);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Apr 23 2003 - 22:00:30 EST