Re: [CHECKER] 6 memory leaks

From: Muli Ben-Yehuda (mulix@mulix.org)
Date: Sat Apr 19 2003 - 05:02:08 EST

On Sat, Apr 19, 2003 at 02:55:26AM -0700, William Lee Irwin III wrote:
> On Sat, Apr 19, 2003 at 12:44:45PM +0300, Muli Ben-Yehuda wrote:
> > Index: net/irda/irttp.c
> > ===================================================================
> > RCS file: /home/cvs/linux-2.5/net/irda/irttp.c,v
> > retrieving revision 1.12
> > diff -u -r1.12 irttp.c
> > --- net/irda/irttp.c 25 Feb 2003 05:02:46 -0000 1.12
> > +++ net/irda/irttp.c 19 Apr 2003 08:50:00 -0000
> > @@ -263,7 +263,7 @@
> >
> > IRDA_DEBUG(2, "%s(), rx_sdu_size=%d\n", __FUNCTION__,
> > self->rx_sdu_size);
> > - ASSERT(n <= self->rx_sdu_size, return NULL;);
> > + ASSERT(n <= self->rx_sdu_size, {dev_kfree_skb(skb); return NULL;});
> >
> > /* Set the new length */
> > skb_trim(skb, n);
>
> I'm in terror. ASSERT()? return NULL in a macro argument?
> Any chance of cleaning that up a bit while you're at it?

I'm afraid it's rather wide-spread...

mulix@granada:~/kernel/cvs/linux-2.5$ grep ASSERT net/irda/*.c | grep return | wc -l
    511

I'm willing to do the grunt work of converting it, if it's ok with the
IRDA maintainers. 

-- 
Muli Ben-Yehuda
http://www.mulix.org
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Wed Apr 23 2003 - 22:00:25 EST