On Fri, 18 Apr 2003, Christoph Hellwig wrote:
> @@ -1456,8 +1455,8 @@
> dev_t devnum = 0, dev = MKDEV(major, minor);
> struct devfs_entry *de;
>
> - if (flags)
> - printk(KERN_ERR "%s called with flags != 0, please fix!\n");
> + /* we don't accept any flags anymore. prototype will change soon. */
> + BUG_ON(flags);
PLEASE don't use BUG_ON() except for conditions that you really cannot
continue from. It's damn impolite (and it makes debugging impossible) to
kill the kernel startup if somebody has a unconverted driver or similar.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Apr 23 2003 - 22:00:24 EST