Re: [PATCH] More USB fixes for 2.5.67

From: Greg KH (greg@kroah.com)
Date: Thu Apr 17 2003 - 01:05:04 EST

ChangeSet 1.1059, 2003/04/14 10:21:36-07:00, greg@kroah.com

[PATCH] USB: kl5kusb105 fix up errors found by smatch

diff -Nru a/drivers/usb/serial/kl5kusb105.c b/drivers/usb/serial/kl5kusb105.c
--- a/drivers/usb/serial/kl5kusb105.c Wed Apr 16 10:49:14 2003
+++ b/drivers/usb/serial/kl5kusb105.c Wed Apr 16 10:49:14 2003
@@ -964,8 +964,9 @@
              if (retval)
                          return(retval);
 
- kernel_termios_to_user_termios((struct termios *)arg,
- &priv->termios);
+ if (kernel_termios_to_user_termios((struct termios *)arg,
+ &priv->termios))
+ return -EFAULT;
              return(0);
              }
         case TCSETS: {
@@ -980,8 +981,9 @@
                 if (retval)
                             return(retval);
 
- user_termios_to_kernel_termios(&priv->termios,
- (struct termios *)arg);
+ if (user_termios_to_kernel_termios(&priv->termios,
+ (struct termios *)arg))
+ return -EFAULT;
                 klsi_105_set_termios(port, &priv->termios);
                 return(0);
              }

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Wed Apr 23 2003 - 22:00:20 EST