Re: [PATCH] [2.5] include/asm-generic/bitops.h {set,clear}_bit return void

• Next message: Patrick Mochel: "Re: New Software Suspend Patch for testing."
• Previous message: Eli Carter: ".section ... "ax" vs #alloc, #execinstr"
• Next in thread: Carl-Daniel Hailfinger: "Re: [PATCH] [2.5] include/asm-generic/bitops.h {set,clear}_bit return void"
• Reply: Carl-Daniel Hailfinger: "Re: [PATCH] [2.5] include/asm-generic/bitops.h {set,clear}_bit return void"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Carl-Daniel Hailfinger wrote:

> + mask = 1 << (nr & 0x1f);
> + cli();
> + *addr |= mask;
> + sti();

cli() and sti() are no more. Moreover, the file you are trying to fix is
not even used anywhere. Better submit a patch to remove it completely.

        Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Patrick Mochel: "Re: New Software Suspend Patch for testing."
• Previous message: Eli Carter: ".section ... "ax" vs #alloc, #execinstr"
• Next in thread: Carl-Daniel Hailfinger: "Re: [PATCH] [2.5] include/asm-generic/bitops.h {set,clear}_bit return void"
• Reply: Carl-Daniel Hailfinger: "Re: [PATCH] [2.5] include/asm-generic/bitops.h {set,clear}_bit return void"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue Apr 15 2003 - 22:00:36 EST