Re: BUGed to death

From: Dave Jones (davej@codemonkey.org.uk)
Date: Tue Apr 15 2003 - 07:36:45 EST


On Tue, Apr 15, 2003 at 02:31:34PM +0200, Jens Axboe wrote:

> If you do that, you must audit every single BUG_ON to make sure the
> expression doesn't have any side effects.
>
> BUG_ON(do_the_good_stuff());

Sure, but such a construct looks really bad anyway.
Relying on side-effects of whats essentially a debug macro
sounds very dodgy.

        foo = do_the_good_stuff();
        BUG_ON (foo==baz)

Would be a better way of expressing this.

                Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Apr 15 2003 - 22:00:35 EST