Re: [PATCH] kill two scsi ioctls

From: Andries.Brouwer@cwi.nl
Date: Thu Apr 10 2003 - 12:29:11 EST


    On Thu, Apr 10, 2003 at 06:33:26PM +0200, Andries.Brouwer@cwi.nl wrote:

> The definition for SCSI_IOCTL_BENCHMARK_COMMAND was added in 1.1.2.
> The definition for SCSI_IOCTL_SYNC was added in 1.1.38.
> Neither of them has ever been used.

    Can't you at least add a comment about what was there ? It's quite
    annoying to come across :

    #define FOO 1
    #define BAR 2
    #define BAZ 5

    and have no idea why

It happens all the time. Hundreds of cases.

I prefer a short and clean actual kernel source, and long
historical explanations somewhere else, for example in
Documentation/ioctl_list.

(Michael Elizabeth Chastain made ioctl_list.2 a man page,
but nobody keeps it up-to-date. The current version is from
1.3.27. I am updating it and expect to submit it for the
Documentation directory. Maybe more people will update it there.)

Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Apr 15 2003 - 22:00:21 EST