Re: [patch] acpi compile fix

From: Dave Jones (davej@codemonkey.org.uk)
Date: Fri Apr 04 2003 - 07:18:12 EST


On Thu, Apr 03, 2003 at 01:05:05PM -0800, Andrew Morton wrote:

> diff -puN drivers/acpi/osl.c~acpi-spinlock-casts drivers/acpi/osl.c
> --- 25/drivers/acpi/osl.c~acpi-spinlock-casts Thu Apr 3 13:00:54 2003
> +++ 25-akpm/drivers/acpi/osl.c Thu Apr 3 13:01:25 2003
> @@ -736,7 +736,7 @@ acpi_os_acquire_lock (
> if (flags & ACPI_NOT_ISR)
> ACPI_DISABLE_IRQS();
>
> - spin_lock(handle);
> + spin_lock((spinlock_t *)handle);

Is there a reason these functions can't just have their arguments
changed to take a spinlock_t* instead of an acpi_handle ?
That cast looks really fugly IMO.

                Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Apr 07 2003 - 22:00:22 EST