Re: [PATCH] reduce stack in cpqarray.c::ida_ioctl()

From: Jens Axboe (axboe@suse.de)
Date: Fri Apr 04 2003 - 03:09:37 EST

Next message: Denis Vlasenko: "Re: [BUG] E7x05 chipset bug in 2.5 kernels' AGPGART driver."
Previous message: Maciej Soltysiak: "Re: 2.5.66-mm2"
In reply to: Jörn Engel: "Re: [PATCH] reduce stack in cpqarray.c::ida_ioctl()"
Next in thread: Jörn Engel: "Re: [PATCH] reduce stack in cpqarray.c::ida_ioctl()"
Reply: Jörn Engel: "Re: [PATCH] reduce stack in cpqarray.c::ida_ioctl()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Fri, Apr 04 2003, Jörn Engel wrote:
> > + error = copy_to_user(io, my_io, sizeof(*my_io)) ? -EFAULT : 0;
>
> copy_to_user returns the bytes successfully copied.
> error is set to -EFAULT, if there was actually data transferred?
>
> How about:
> + error = copy_to_user(io, my_io, sizeof(*my_io)) < sizeof(*my_io) ? -EFAULT : 0;

Pure nonsense! Correct logic, and much nicer to read IMO is:

if (copy_to_user(io, my_io, sizeof(*my_io))
error = -EFAULT;

-- Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Denis Vlasenko: "Re: [BUG] E7x05 chipset bug in 2.5 kernels' AGPGART driver."
Previous message: Maciej Soltysiak: "Re: 2.5.66-mm2"
In reply to: Jörn Engel: "Re: [PATCH] reduce stack in cpqarray.c::ida_ioctl()"
Next in thread: Jörn Engel: "Re: [PATCH] reduce stack in cpqarray.c::ida_ioctl()"
Reply: Jörn Engel: "Re: [PATCH] reduce stack in cpqarray.c::ida_ioctl()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Apr 07 2003 - 22:00:22 EST