[PATCH] tmpfs 3/6 use generic_file_llseek

• Next message: Hugh Dickins: "[PATCH] tmpfs 4/6 use mark_page_accessed"
• Previous message: Hugh Dickins: "[PATCH] tmpfs 2/6 remove shmem_readpage"
• In reply to: Hugh Dickins: "[PATCH] tmpfs 1/6 use generic_write_checks"
• Next in thread: Hugh Dickins: "[PATCH] tmpfs 4/6 use mark_page_accessed"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

default_llseek's use of BKL and not i_sem was recently exposed:
tmpfs should be using generic_file_llseek which guards with i_sem.

--- tmpfs2/mm/shmem.c Tue Apr 1 21:34:59 2003
+++ tmpfs3/mm/shmem.c Tue Apr 1 21:35:10 2003
@@ -1749,6 +1749,7 @@
 static struct file_operations shmem_file_operations = {
         .mmap = shmem_mmap,
 #ifdef CONFIG_TMPFS
+ .llseek = generic_file_llseek,
         .read = shmem_file_read,
         .write = shmem_file_write,
         .fsync = simple_sync_file,

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Hugh Dickins: "[PATCH] tmpfs 4/6 use mark_page_accessed"
• Previous message: Hugh Dickins: "[PATCH] tmpfs 2/6 remove shmem_readpage"
• In reply to: Hugh Dickins: "[PATCH] tmpfs 1/6 use generic_write_checks"
• Next in thread: Hugh Dickins: "[PATCH] tmpfs 4/6 use mark_page_accessed"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Apr 07 2003 - 22:00:15 EST