Re: x.25 bug

From: Alan Cox (alan@lxorguk.ukuu.org.uk)
Date: Fri Mar 28 2003 - 12:11:01 EST


On Fri, 2003-03-28 at 06:00, Tiaan Wessels wrote:
> [X.] Other notes, patches, fixes, workarounds:
> in net/x25/x25_facilities.c function x25_parse_facilities
> there is switch with case X25_FAC_CLASS_D which has code
>
> p += p[1] + 2;
> len -= p[1] + 2;
>
> the problem is in decrementing len, p is used after it was modified
> in previous statement. i suspect cut-and-paste here. to fix one
> would put p[1] in temp variable of unsigned char first and then use
> this instead of p[1] in these statements. if this is not done and
> a call arrives with class D facilities, we see a faint blinking of
> the eye before lights goes out.
>
> can someone more familiar with the kernel patch process please update
> the latest sources.

PS: In the mean time if nobody else is looking at it, I'll take a look
at this bit too

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Mar 31 2003 - 22:00:32 EST