Re: [FIX] Re: 2.5.66 new fbcon oops while loading X

From: Wichert Akkerman (wichert@wiggy.net)
Date: Wed Mar 26 2003 - 09:54:12 EST

Previously bert hubert wrote:
> On Debian, ls /dev/fb[67] results in:
> crw--w--w- 1 root tty 29, 192 Nov 30 2000 /dev/fb6
> crw--w--w- 1 root tty 29, 224 Nov 30 2000 /dev/fb7

Documentation/devices.txt (at least in 2.5.64) states that those
devices should be fully supported:

                For backwards compatibility {2.6} the following
                progression is also handled by current kernels:
                  0 = /dev/fb0
                 32 = /dev/fb1
                    ...
                224 = /dev/fb7

So perhaps the patch should look something like:

if (fbidx >= FB_MAX) {
        /* Support older device minor numbering */
        if (fbidx%32!=0)
                return -ENODEV;
        else
                fbidx/=32;

        /* Check if it is still too large */
        if (fbidx >= FB_MAX)
                return -ENODEV;
}

Wichert. 

-- 
Wichert Akkerman <wichert@wiggy.net>           http://www.wiggy.net/
A random hacker
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Mon Mar 31 2003 - 22:00:24 EST