On Wed, 26 Mar 2003, Geert Uytterhoeven wrote:
> On Tue, 25 Mar 2003 Andries.Brouwer@cwi.nl wrote:
> > Good! But I don't see my compilation fixes. Will resend.
> > Below a new one.
> >
> > Andries
> >
> > diff -u --recursive --new-file -X /linux/dontdiff a/fs/partitions/msdos.c b/fs/partitions/msdos.c
> > --- a/fs/partitions/msdos.c Mon Feb 24 23:02:56 2003
> > +++ b/fs/partitions/msdos.c Tue Mar 25 06:22:31 2003
> > @@ -219,7 +219,7 @@
> > * Create devices for BSD partitions listed in a disklabel, under a
> > * dos-like partition. See parse_extended() for more information.
> > */
> > -static void
> > +void
> > parse_bsd(struct parsed_partitions *state, struct block_device *bdev,
> > u32 offset, u32 size, int origin, char *flavour,
> > int max_partitions)
>
> Doesn't it make sense to move parse_bsd() to a separate file? Else we have to
> add a dependency on MSDOS_PARTITION to NEC98_PARTITION.
Should have been: ... if BSD_DISKLABEL is set.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.orgIn personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Mar 31 2003 - 22:00:23 EST