Re: Sleeping in illegal context with 2.5.65-mm2

From: Max Krasnyansky (maxk@qualcomm.com)
Date: Mon Mar 24 2003 - 16:44:22 EST


At 09:05 PM 3/19/2003, Greg KH wrote:
>On Wed, Mar 19, 2003 at 11:03:51PM -0600, Kai Germaschewski wrote:
>> On Wed, 19 Mar 2003, Greg KH wrote:
>>
>> > > Debug: sleeping function called from illegal context at mm/slab.c:1723
>> > > Call Trace:
>> > > [<c0119d92>] __might_sleep+0x5f/0x65
>> > > [<c013a097>] kmalloc+0x88/0x8f
>> > > [<c0238111>] usb_alloc_urb+0x21/0x51
>> > > [<f09180bc>] hci_usb_enable_intr+0x20/0xf8 [hci_usb]
>> >
>> > The call to usb_alloc_urb() here is being done with the GFP_ATOMIC flag,
>> > which is correct. Do we need to fix up the warning message to prevent
>> > false positives like this from happening?
>>
>> Not in my tree: (drivers/bluetooth/hci_sb.c)
>>
>> if (!(urb = usb_alloc_urb(0, GFP_KERNEL)))
>> return -ENOMEM;
>
>Doh, nevermind, I was looking at the wrong function, sorry.
>
>> And the function is called in a write_lock_irqsave(), so the complaint is
>> justified.
>
>Max, you should probably fix this up.
Will do.

Thanks
Max

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Mar 31 2003 - 22:00:17 EST