Re: sleeping function call in 2.5.65-bk

From: dan carpenter (d_carpenter@sbcglobal.net)
Date: Sat Mar 22 2003 - 20:44:25 EST


On Sunday 23 March 2003 05:30 pm, Brian Gerst wrote:
>
> The fbcon driver is calling kmalloc in interrupt context without
> GFP_ATOMIC.

Good call. This is compile tested only.

regards,
dan carpenter

--- drivers/video/console/fbcon.c.orig 2003-03-23 02:39:23.000000000 +0100
+++ drivers/video/console/fbcon.c 2003-03-23 02:40:39.000000000 +0100
@@ -985,8 +985,8 @@
 
        size = ((width + 7) >> 3) * height;
 
- data = kmalloc(size, GFP_KERNEL);
- mask = kmalloc(size, GFP_KERNEL);
+ data = kmalloc(size, GFP_ATOMIC);
+ mask = kmalloc(size, GFP_ATOMIC);
        
        if (cursor->set & FB_CUR_SETSIZE) {
                memset(data, 0xff, size);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Mar 23 2003 - 22:00:45 EST